Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue related to quoted identifier in Pgsql. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix an issue related to quoted identifier in Pgsql. #3

wants to merge 1 commit into from

Conversation

Drup
Copy link
Member

@Drup Drup commented Nov 8, 2013

This should be safe, but it may breaks other people code as it makes all tables names case sensitive.
I need it and I used it for quite a while, but I'm not sure it's mergeable.

@gasche
Copy link
Contributor

gasche commented Dec 19, 2013

You turn a %s into a "%s". I understand that %S wouldn't be quite right (OCaml's lexical conventions are not SQL's), but isn't there a potential problem with quotes needing to be escaped? I assume you rely on the parser rejecting them, but that's not good style.

@jrochel jrochel force-pushed the master branch 4 times, most recently from 19cc6de to a92e91c Compare November 18, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drup @gasche